Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCONNECTED_ROUTE cases can reverse the wrong routes #778

Open
yakra opened this issue Mar 1, 2024 · 2 comments
Open

DISCONNECTED_ROUTE cases can reverse the wrong routes #778

yakra opened this issue Mar 1, 2024 · 2 comments
Labels
bug showroute The showroute.php functionality of the HB

Comments

@yakra
Copy link
Contributor

yakra commented Mar 1, 2024

TravelMapping/DataProcessing#610
Note the old commits shown in the OP. We won't see this on production noreaster right now.

https://github.com/TravelMapping/HighwayData/blob/2decc64/hwy_data/_systems/indnh_con.csv#L14
indup.nh044-e gets reversed by siteupdate.
indup.nh044-w gets reversed by showroute.

We should get the same behavior from siteupdate and showroute.
Let's not change showroute just yet though; I'll be changing what siteupdate does soon.

@yakra yakra added bug showroute The showroute.php functionality of the HB labels Mar 1, 2024
@yakra
Copy link
Contributor Author

yakra commented Jun 13, 2024

DISCONNECTED_ROUTE behavior in siteupdate was changed in TravelMapping/DataProcessing#617.

@yakra
Copy link
Contributor Author

yakra commented Oct 22, 2024

To save us from having to replicate the complex logic of the DataProcessing side on the Web side, we could include a new isReversed column in the routes DB table.

I don't expect to be rewriting that in the future, but this can save our butts in case it does happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug showroute The showroute.php functionality of the HB
Projects
None yet
Development

No branches or pull requests

1 participant