From fbfa74152b954000a0e63fb45924c1c301bf813b Mon Sep 17 00:00:00 2001 From: Nirav Sherasiya Date: Mon, 2 Dec 2024 10:26:17 +0530 Subject: [PATCH] Remove setCurrentSlide api --- src/lightbox/README.md | 4 ---- src/lightbox/tp-lightbox-nav-item.ts | 2 +- src/lightbox/tp-lightbox.ts | 30 +++++++--------------------- 3 files changed, 8 insertions(+), 28 deletions(-) diff --git a/src/lightbox/README.md b/src/lightbox/README.md index e017b96..a9261f9 100644 --- a/src/lightbox/README.md +++ b/src/lightbox/README.md @@ -74,7 +74,3 @@ Open the lightbox. ### `close` Close the lightbox. - -### `setCurrentSlide` - -Set the current slide. diff --git a/src/lightbox/tp-lightbox-nav-item.ts b/src/lightbox/tp-lightbox-nav-item.ts index f29c73b..15aec1c 100644 --- a/src/lightbox/tp-lightbox-nav-item.ts +++ b/src/lightbox/tp-lightbox-nav-item.ts @@ -36,7 +36,7 @@ export class TPLightboxNavItemElement extends HTMLElement { } // Set current slide. - this.lightbox.setCurrentSlide( this.getIndex() ); + this.lightbox.currentIndex = Number( this.getIndex() ) ?? 1; // Update navigation current item. this.lightbox.updateNavCurrentItem(); diff --git a/src/lightbox/tp-lightbox.ts b/src/lightbox/tp-lightbox.ts index ec7c912..a4dfa67 100644 --- a/src/lightbox/tp-lightbox.ts +++ b/src/lightbox/tp-lightbox.ts @@ -165,6 +165,13 @@ export class TPLightboxElement extends HTMLElement { index = 1; } + // dispatch slide-set event. + this.dispatchEvent( new CustomEvent( 'slide-set', { + detail: { + slideIndex: index, + }, + } ) ); + // Setting this attributes triggers a re-trigger. this.setAttribute( 'index', index.toString() ); } @@ -491,29 +498,6 @@ export class TPLightboxElement extends HTMLElement { } } - /** - * Set the current slide index. - * - * @param {number} index Slide index. - */ - setCurrentSlide( index: number ): void { - // Check if slide index is valid. - if ( index > Number( this.getAttribute( 'total' ) ) || index <= 0 ) { - // Stop! It's not valid. - return; - } - - // dispatch slide-set event. - this.dispatchEvent( new CustomEvent( 'slide-set', { - detail: { - slideIndex: index, - }, - } ) ); - - // Set current slide index. - this.setAttribute( 'index', index.toString() ); - } - /** * Update current item in navigation. */