Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Table: Incorrect <thead> Markup #22

Closed
sagarjadhav opened this issue Aug 6, 2024 · 5 comments
Closed

Block Table: Incorrect <thead> Markup #22

sagarjadhav opened this issue Aug 6, 2024 · 5 comments
Assignees

Comments

@sagarjadhav
Copy link

The current markup is incorrect and should be fixed. The problematic code is as follows:

<thead>
  <tr>
    <td>T Header</td>
    <td>T Header</td>
  </tr>
</thead>

The correct markup should be:

<thead>
  <tr>
    <th>T Header</th>
    <th>T Header</th>
  </tr>
</thead>
@junaidbhura
Copy link
Contributor

@abhi3315 Would you be able to take a look at this one?

@sagarjadhav In the meantime, please add styles for both in the website's CSS, so when this is updated - it will work too

@abhi3315
Copy link
Contributor

abhi3315 commented Aug 7, 2024

@junaidbhura I have raised the PR. Please take a look.
#23

junaidbhura added a commit that referenced this issue Aug 7, 2024
@junaidbhura
Copy link
Contributor

Thanks @abhi3315 !

@sagarjadhav a new version is released, can you please check if this fixes your issue? https://github.com/Travelopia/wordpress-blocks/releases/tag/1.1.1

@sagarjadhav
Copy link
Author

@junaidbhura This is working as expected. Thanks

@junaidbhura
Copy link
Contributor

Thanks @sagarjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants