The arguments to create_subcom are not clear

[devos50]

The create_subcom method currently has the following signature:

def create_subcom(self, *args, **kwargs) -> BaseSubCommunity:

From this signature alone, is not clear what arguments are expected here. The call to this method gave me a bit more information, but I think the expected arguments should be added to the signature:

subcom = self.subcom_factory.create_subcom(
                subcom_id=subcom_id, max_peers=self.settings.subcom_max_peers
            )

[Solomon1732]

It seems there are at least three places where the create_subcom method is implemented. In all three places it looks to be a wrapper around either IPv8SubCommunity or LightSubCommunity.

https://github.com/Tribler/bami/blob/master/src/bami/backbone/community.py#L205
https://github.com/Tribler/bami/blob/master/src/bami/backbone/sub_community.py#L80
https://github.com/Tribler/bami/blob/master/src/bami/backbone/sub_community.py#L100

The last link, which calls LightSubCommunity, also requires only subcom_id, while LightSubCommunity requires that and max_peers, the latter of which is unused in the class.
LightSubCommunity:
https://github.com/Tribler/bami/blob/master/src/bami/backbone/sub_community.py#L54

Even though it is unused, it still can give a clue as to what is the expected type of each argument. In this case they both look like int.