Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of block_response is abstract but has to be called by the developer itself #13

Open
devos50 opened this issue Oct 2, 2020 · 0 comments
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@devos50
Copy link
Collaborator

devos50 commented Oct 2, 2020

I found that the implementation of the block_response is required. Therefore, I would expect that this implementation is critical when running a simple community derived from the backbone. However, the PaymentCommunity reveals that the developer has to call the block_response manually when processing incoming blocks. I think it would be helpful to move the primitives for confirming/responding to blocks to the backbone. For example, we can provide a method in the backbone, should_counter_sign, that is called on every incoming block, and return True when we respond to that block. Then, the block_response method is called.

@grimadas grimadas added bug Something isn't working enhancement New feature or request labels Oct 5, 2020
@grimadas grimadas added this to the Better API milestone Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants