Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move next peer selection strategies to a separate file #48

Open
devos50 opened this issue Oct 8, 2020 · 1 comment
Open

Move next peer selection strategies to a separate file #48

devos50 opened this issue Oct 8, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@devos50
Copy link
Collaborator

devos50 commented Oct 8, 2020

The strategies to select a peer during the frontier gossip are currently located in the gossip.py. Even though the are an essential part of the gossip strategies, they can be moved to a separate file for a cleaner code organisation.

@devos50 devos50 added the enhancement New feature or request label Oct 8, 2020
@Solomon1732
Copy link

Solomon1732 commented Oct 2, 2021

From what I can see peer selection strategies are done in the following three classes: NextPeerSelectionStrategy, RandomPeerSelectionStrategy, and SmartPeerSelectionStrategy. If this is correct, then they can be moved to a new file. Of course, some tests would have to be updated to match the new locations.

Edit: talking about https://github.com/Tribler/bami/blob/master/src/bami/plexus/backbone/gossip.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants