Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config formatting #76

Open
caojohnny opened this issue Jun 24, 2017 · 4 comments
Open

Config formatting #76

caojohnny opened this issue Jun 24, 2017 · 4 comments
Labels
bug discuss
Milestone
0.6-alpha

Comments

@caojohnny
Copy link
Member

Configs currently cannot hold comments or integer values (they can only be floating point or double for whatever reason).
@locxFIN
Copy link

locxFIN commented Jun 24, 2017

@AgentTroll Wew

@caojohnny caojohnny added this to the 0.5-alpha milestone Jun 24, 2017
@caojohnny
Copy link
Member Author

Seems to be a problem with saving the config itself

@nickrobson
Copy link
Contributor

Is this a problem stemming from the Config class?

IMO, we should overall the config package into a more abstract method, with a JsonConfig implementation: allowing the possibility for other formats.

@caojohnny
Copy link
Member Author

The config stuff is already quite well abstracted, I'm not sure what else would go into that

@caojohnny caojohnny modified the milestones: 0.6-alpha, 0.5-alpha Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug discuss
Projects
None yet
Milestone
0.6-alpha
Development

No branches or pull requests
3 participants
@caojohnny @nickrobson @locxFIN