Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dump-db in releases is shipped as TS #1115

Open
pano9000 opened this issue Feb 4, 2025 · 2 comments
Open

dump-db in releases is shipped as TS #1115

pano9000 opened this issue Feb 4, 2025 · 2 comments

Comments

@pano9000
Copy link
Contributor

pano9000 commented Feb 4, 2025

Describe Task

Hi,

I was noticing that we bundle the dump-db tool in the release files, however we are actually shipping TS version, which of course currently does not work "out-of-the-box" with node (with currently released Node versions you would need to use some extra experimental flags).

We should correct that for future releases

@pano9000
Copy link
Contributor Author

@eliandoran
I even wonder:

do we even want to ship dump-db with the releases?
In Electron releases e.g. – no one will be able to use it anyways, even if it was shipped as JS file (if I am not fully mistaken).

Alternative idea:
Should we potentially have this "released" as separate package at some point even?
e.g. together with https://github.com/TriliumNext/trilium-db-compare

We could have a "trilium-db-tools" type package containing dump-db and db-compare, for those people that need it.

This would go hand-in-hand with your eventual mono-repo idea :-)

@eliandoran
Copy link
Contributor

@pano9000 , my opinion is we shouldn't ship it at all for now, I don't see any benefit for the end user, at least for now.
And yes, we could ship it as an external tool.
For now it would be good not to include it, but I wouldn't spend too much time on it since it's a small file.
It should disappear on its own once we build the monorepo, since it'll go in a separate entrypoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants