Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge cases when updating assets that already have manifest data #55

Open
cyraxx opened this issue Aug 8, 2024 · 0 comments
Open

Edge cases when updating assets that already have manifest data #55

cyraxx opened this issue Aug 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@cyraxx
Copy link
Contributor

cyraxx commented Aug 8, 2024

Some interesting edge cases are left after the implementation of splicing a manifest into assets (#45) that might occur when an asset is manipulated that already had existing manifest data:

  • For both PNG and JPEG: If an asset contains multiple manifest stores, this is ignored and treated as if there is no manifest store (in line with the specification). However, during manifest insertion, we then insert a new manifest store, which would cause the asset to still have multiple stores and be invalid. The fix is relatively simple: Instead of relying on the cached information that there is no manifest store, go through all chunks/boxes and remove any existing manifest stores.
  • For BMFF: If an existing C2PA uuid box appears anywhere after the meta box, the file offsets in iloc will likely be wrong. Also, any non-top-level C2PA boxes (e.g. for Merkle hashing) are currently ignored and might cause issues. Both of these need to be investigated further.
@cyraxx cyraxx added the bug Something isn't working label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant