Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer dependency compatibility with Gatsby 4.0 #199

Closed
broksonic21 opened this issue Oct 21, 2021 · 10 comments
Closed

Peer dependency compatibility with Gatsby 4.0 #199

broksonic21 opened this issue Oct 21, 2021 · 10 comments

Comments

@broksonic21
Copy link

Issue Summary

Gatsby 4.0 is out but gatsby-plugin-advanced-sitemap restricts the peer dependency to 3.0. This blocks running npm audit fix, amongst other projects. Is there a plan to update? Looks like renovate is trying to at #198

To Reproduce

See https://github.com/TryGhost/gatsby-plugin-advanced-sitemap/blob/master/package.json#L32

  1. have a package.json with Gatsby 4.0 and gatsby-plugin-advanced-sitemap 2.0
  2. run npm audit fix (using node 16)
  3. see it complain on mismatch on peer dependency

Technical details:

  • Gatsby Version: 4.0
  • Node Version: 16.11.1
  • OS: Mac
@broksonic21
Copy link
Author

is there an update on a new version for this?

@gauthamilango
Copy link

gauthamilango commented Nov 12, 2021

Anyone working on this?

@julrich
Copy link

julrich commented Nov 12, 2021

Also waiting for this! 👀
So far it's working flawlessly (as far as I can judge that) for us on v4, it's just the warning!

@hisnameisjimmy
Copy link

Also would love this!

@simon-abbott
Copy link

simon-abbott commented Dec 22, 2021

I can confirm that it breaks with gatsby 4.4.0 because it's using pify, but not declaring it as a dependency.

import pify from 'pify';

"dependencies": {
"@babel/runtime": "7.14.0",
"fs-extra": "10.0.0",
"lodash": "4.17.21",
"moment": "2.29.1",
"xml": "^1.0.1"
}

Not entirely sure how it was working until now, but it isn't anymore.

@Hahlh
Copy link

Hahlh commented Jan 12, 2022

@simon-abbott Could you please speficy in what way it exactly breaks in your case?

I have currently brought a project up to 4.5.2 and despite the compability warning, the plugin still seems to correctly generate the sitemaps in my case.

@nazzart
Copy link

nazzart commented Jan 25, 2022

@Hahlh , I have same issue. It doesnt work with gatsby 4.2.
The error message I get durring the build is:
Error: Cannot find module 'pify'
Plugin gatsby-plugin-advanced-sitemap is not compatible with your gatsby version 4.2.0 - It requires gatsby@^3.0.0

@thibaultcrouzet
Copy link

warn Plugin gatsby-plugin-advanced-sitemap is not compatible with your gatsby version 4.5.5 - It requires gatsby@^3.0.0
any update soon?

@tony
Copy link

tony commented Feb 24, 2022

There is a new package: gatsby-plugin-complex-sitemaps

Haven't tried it yet, but there's a migration guide from gatsby-plugin-advanced-sitemap

@yogeshkotadiya
Copy link
Collaborator

Fixed in release v2.1.0: #178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants