Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another approach to content delivery with embedding option #30

Open
svewap opened this issue Mar 2, 2022 · 1 comment
Open

Another approach to content delivery with embedding option #30

svewap opened this issue Mar 2, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@svewap
Copy link

svewap commented Mar 2, 2022

Hello,
in order to be able to create a uniform interface for generating a URL that is always the same, I have written a proxy script via middleware: <domain>/h5p/embed/<id>
In addition, I have rewritten the controller so that the content now runs in a proper iframe and no additional JavaScript is loaded on the TYPO3 page. This had always led to conflicts with other jQuery versions.
Maybe it is interesting for you. You can find a demo below.

https://github.com/svewap/t3ext-h5p/tree/feature/embedded

https://v10.typo3-playground.wappler.systems/de/extensions/h5p/

@Tuurlijk
Copy link
Owner

Hi Sven,

Nice. Can you make it so it can be switched on and off by a config option? Or is it handled through Services?

Can you make a pr?

@Tuurlijk Tuurlijk added the enhancement New feature or request label Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants