Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] dependencies crashing #138

Open
kevinchern opened this issue Jun 21, 2019 · 2 comments
Open

[CLI] dependencies crashing #138

kevinchern opened this issue Jun 21, 2019 · 2 comments

Comments

@kevinchern
Copy link
Collaborator

Current code not robust.
Reproduce by creating a dependencies.txt as follows:

ca.ubc.stat:conifer:2.0.4

note empty line
NOT

ca.ubc.stat:conifer:2.0.4

call blang cli and it should crash.
standalone compiler tries to do compile ''
@alexandrebouchard
Copy link
Contributor

Good point, and we might as well add a bit more validation that each line should have the format "^.+[:].+[:].+$" and print a meaningful message if it does not.

@kevinchern
Copy link
Collaborator Author

we will send a pull request soon :)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexandrebouchard @kevinchern