Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @override decorator in Python code #3385

Open
1 task
williamckha opened this issue Oct 24, 2024 · 0 comments
Open
1 task

Use @override decorator in Python code #3385

williamckha opened this issue Oct 24, 2024 · 0 comments
Labels
Code Quality Code readability, SOLID principles Difficulty - 1 The easiest and simplest issues, and they are tasks that can be done by new members

Comments

@williamckha
Copy link
Contributor

Description of the task

Python 3.12 adds an @override decorator that we should use.

We can borrow the javadoc convention where methods marked with @override do not require docstrings (unless the overriding method has some more specific behaviour that needs to be documented).

Acceptance criteria

  • Mark all methods that override a method or implement an abstract method with @override

Blocked By

@williamckha williamckha added Difficulty - 1 The easiest and simplest issues, and they are tasks that can be done by new members Code Quality Code readability, SOLID principles labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Quality Code readability, SOLID principles Difficulty - 1 The easiest and simplest issues, and they are tasks that can be done by new members
Projects
None yet
Development

No branches or pull requests

1 participant