Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTT measurements should be reported per-robot #3391

Open
3 tasks
itsarune opened this issue Oct 24, 2024 · 0 comments
Open
3 tasks

RTT measurements should be reported per-robot #3391

itsarune opened this issue Oct 24, 2024 · 0 comments
Assignees
Labels
Difficulty - 3 Easy and simple issues that require some context to do Needs Hardware This ticket needs extra hardware, like a robot or development board to work on Thunderscope

Comments

@itsarune
Copy link
Contributor

Description of the task

We use round-trip time as a measure of how long it takes for us to communicate with the robots. We send the timestamp of sent packets in the PrimitiveSet (PC -> robot) and report the timestamp in RobotStatus (robot -> PC). This round-trip is forwarded to Thunderscope when we receive it in RobotCommunication. which is visualized here. (This widget is visible when ./tbots.py run thunderscope_main is run with the --run_blue or --run_yellow or --run_diagnostics flags).

A problem is that we lose the associated RobotId when that proto gets forwarded to Thunderscope. We end up assuming the latest available RobotStatus is associated with that RobotStatistic but that may not be the case.

We should create a new robot_id field that can be taken from RobotStatus when it is created in the RobotCommunication module. Then, we should decouple the robot widget update logic so that we can update the RTT and RobotStatus separately.

Acceptance criteria

  • Update the RobotStatistic definition to include the robot_id and fill it out in RobotCommunication
  • Decouple the logic to update the RTT and RobotStatus in robot_view.py
  • Test that these changes work with a robot on the field

Blocked By

@itsarune itsarune added Difficulty - 3 Easy and simple issues that require some context to do Needs Hardware This ticket needs extra hardware, like a robot or development board to work on Thunderscope labels Oct 24, 2024
@Muxite Muxite assigned Muxite and unassigned Muxite Nov 4, 2024
@AmyKawa AmyKawa self-assigned this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty - 3 Easy and simple issues that require some context to do Needs Hardware This ticket needs extra hardware, like a robot or development board to work on Thunderscope
Projects
None yet
Development

No branches or pull requests

3 participants