Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate IO from Assertions #30

Merged
merged 4 commits into from
Sep 11, 2018
Merged

Separate IO from Assertions #30

merged 4 commits into from
Sep 11, 2018

Conversation

cjnickel
Copy link
Contributor

@cjnickel cjnickel commented Aug 31, 2018

This PR is to introduce the reporter concept with the printSummary function that operates on the current failure message structure.

Like I mentioned in #28 I've left out color for now and just added square brackets around it to help separate it from the message itself.
screen shot 2018-08-30 at 8 15 54 pm

Also, added a commit to make the fatal error output follow same format as warnings.
image

@cjnickel cjnickel requested a review from TrueWill as a code owner August 31, 2018 00:17
@cjnickel cjnickel force-pushed the feature/separate-io branch from bc0d238 to ccc3bf8 Compare August 31, 2018 00:36
@TrueWill
Copy link
Contributor

Going to bump the version then merge.

@TrueWill TrueWill merged commit e757d6d into master Sep 11, 2018
@TrueWill TrueWill deleted the feature/separate-io branch September 11, 2018 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants