Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymorphic version for different obs in obsop #129

Open
cd10kfsu opened this issue Aug 26, 2022 · 4 comments
Open

Polymorphic version for different obs in obsop #129

cd10kfsu opened this issue Aug 26, 2022 · 4 comments

Comments

@cd10kfsu
Copy link
Collaborator

This issue should be labeled as features.

@StevePny @sanAkel later I will probably need to create a polymorphic version to store different observation types for obsop.
The reason is that different SST files might be of different formats, and have different properties. As we add more obs types into Ocean-LETKF, it creates a lot of repetitive codes as shown in obsop_*

It should be possible to define

type, abstract :: t_obs
<properties>
contains
procedure(get_loc_) :: get_loc
procedure(get_obsval_) :: get_obsval
....

and we can then define

type, extends(t_obs) :: t_sst_g17_abi_obs
type, extends(t_obs) :: t_sst_h08_ahi_obs
type, extends(t_obs) :: t_sss_jpl_l2b_obs
type, extends(t_obs) :: t_adt_avisio_obs
@sanAkel
Copy link
Collaborator

sanAkel commented Aug 26, 2022

You could do that @cd10kfsu or have a yaml file that can be read in. See this https://github.com/Goddard-Fortran-Ecosystem/yaFyaml from @tclune, @mathomp4, and others.

@gmao-cda
Copy link
Contributor

@sanAkel Thanks Santha. Currently I will leave it as the current state.
Preparing a minimal sample model output from GEOSgcm for obsop test.

@cd10kfsu
Copy link
Collaborator Author

cd10kfsu commented Mar 9, 2023

Create observers for those top-level obs:

  • SST
  • SSS
  • profile
  • radiance
  • precipitation

@gmao-cda
Copy link
Contributor

gmao-cda commented Nov 7, 2023

Follow obsop in GEOSFV3-LETKF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants