Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix equivication between variables in expressions and rules #49

Open
bemica opened this issue Apr 3, 2019 · 2 comments
Open

Fix equivication between variables in expressions and rules #49

bemica opened this issue Apr 3, 2019 · 2 comments

Comments

@bemica
Copy link
Collaborator

bemica commented Apr 3, 2019

Because the variables used in rules are considered completely separate than the variables used in expressions, there is some unexpected behavior.

e.g. If the rule is p≡q, the user probably intends to substitute p in the left hand expression with q in the right hand expression. However, this rule actually means "any expression is equivalent to any other expression" and will always validate on any two expressions

@NicMcPhee
Copy link
Member

I'm not really sure what your intent here is. Do you think we should have a syntax that allows us to essentially define constants (e.g., x = 4 that allows us to replace x with 4)?

@bemica
Copy link
Collaborator Author

bemica commented Jan 13, 2020

I think that would be good. The syntax with variables seems just very unintuitive to me, because a variable x in expressions has no relation to a variable x in the rule. But maybe it would be sufficient to just add some warning if the user uses the same variable name in expressions and rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants