-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with black #5
Comments
@anardek Can you point me to the errors you are seeing for black (or how I can reproduce the error)? |
@mcflugen I think the error was actually stemming from other issues, but I misread the deprecation message as the source. I just reformatted the saving/variable passing classes in chome to all have properties (some with setters), which allowed me to find the other errors that black and flake were finding (my pycharm error window was full of "access to protected variable warnings"). Another question: for the chome classes AgentCommon, VariableSave, ManagmentParameters, and ModelParameters, I've been initializing the variables as protected variables in the class. Is this necessary given that I'm passing all these variables to other functions? I ended up creating A LOT of properties. |
And another question @mcflugen - have you seen a good schematic recently to illustrate a coupled model (like CASCADE)? I drew that terrible diagram for you last week, and that's generally what I was going to go with but maybe in a time loop? |
Black tests appear to be failing on all my packages (brie, barrier3d, chome) due to a deprecation of an input argument. @mcflugen, can you help with this?
The text was updated successfully, but these errors were encountered: