Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybamm developers workshop #63

Open
martinjrobins opened this issue Mar 6, 2024 · 1 comment
Open

pybamm developers workshop #63

martinjrobins opened this issue Mar 6, 2024 · 1 comment
Assignees
Labels
new course a new course being developed

Comments

@martinjrobins
Copy link
Collaborator

@brosaplanella:
From the discussions in the meeting today it seems that we may want:

  • Show people how to write a basic model, we can start simple Reservoir, and build all the way to DFN (or SPM) with acid dissolution. - - This will also include writing a parameter set that works for it.
  • We also want that the final task is to write things as a submodel. Even if we don't require this from contributors in the near future, maintainers will have to do it, so still worth documenting it and training people.
  • The day should finish with a PR. Most likely we won't merge any, but people will then have the opportunity to practice with Github and deal with tests, etc.
  • The idea is for people to work in teams, so they can split the work (i.e. treat it as a project, rather than as exercises).
  • We should think of hints or checkpoints to guide people if they get stuck.

Maybe we could start by having a DFN + acid dissolution working script. Then we can work backwards (i.e. any exercises we want to use to teach people how to write models) and forwards (i.e. the submodel version), and also write the statement.

@martinjrobins martinjrobins added the new course a new course being developed label Mar 6, 2024
@martinjrobins martinjrobins self-assigned this Mar 6, 2024
@martinjrobins
Copy link
Collaborator Author

image

martinjrobins added a commit that referenced this issue Mar 6, 2024
martinjrobins added a commit that referenced this issue Mar 6, 2024
martinjrobins added a commit that referenced this issue Mar 6, 2024
martinjrobins added a commit that referenced this issue Mar 6, 2024
martinjrobins added a commit that referenced this issue Mar 6, 2024
martinjrobins added a commit that referenced this issue Mar 6, 2024
martinjrobins added a commit that referenced this issue Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new course a new course being developed
Projects
None yet
Development

No branches or pull requests

1 participant