-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'inpfile_units' affects simulation results #443
Comments
Hi @Walternate0, |
Sorry about that. Here you go.
|
Changing (or commenting out) |
Thanks. My output for the default run (without setting LPS) is
and my output for the run where LPS is set is:
They are slightly different, particularly at J4. I did verify that WNTR is performing the correct conversion when writing the INP files, so I suspect this issue is isolated to EPANET. There are slight rounding errors introduced by EPANET when using converted values, which could explain the difference. One potential way around this is to use the WNTRSimulator, however it cannot do D-W loss. |
Hi @kbonney, |
Sorry, this reply above is incorrect, changing the inpfile_units changes the values in the INP file and the results should be preserved. We did find a potential issue with converting the roughness coefficient, which might be causing the differences. We will look into that very soon. |
Summary
I am using WNTR to model a simple WDN. I create and modify the wn object using WNTR. Changing the 'inpfile_units' attribute provides different results from the simulation (also run in WNTR). From what I understand, this should not be the case.
Example
Environment
Provide information on your computing environment.
The text was updated successfully, but these errors were encountered: