Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/reordering algo properties #163

Merged
merged 8 commits into from
Aug 17, 2021
Merged

Feature/reordering algo properties #163

merged 8 commits into from
Aug 17, 2021

Conversation

salmma
Copy link
Contributor

@salmma salmma commented Aug 16, 2021 •
edited
Loading

reordering properties in overview for

  • algorithms
  • implementations
  • cloud services

solves #152

@salmma salmma requested a review from mbeisel August 16, 2021 13:13
mbeisel
mbeisel reviewed Aug 16, 2021
View reviewed changes
Copy link
Contributor

@mbeisel mbeisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algorithm overview: lgtm
Implementations: Name, contributors, version and license have a rendering buttons that look out of place.
Cloud platforms: lgtm

@salmma salmma requested review from mbeisel and lharzenetter August 16, 2021 15:03
mbeisel
mbeisel approved these changes Aug 16, 2021
View reviewed changes
Copy link
Contributor

@mbeisel mbeisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

lharzenetter
lharzenetter reviewed Aug 17, 2021
View reviewed changes
Copy link
Contributor

@lharzenetter lharzenetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides TODO, LGTM

@salmma salmma merged commit 57e29a5 into master Aug 17, 2021
@salmma salmma deleted the feature/reordering-algo-properties branch August 17, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbeisel mbeisel mbeisel approved these changes

@lharzenetter lharzenetter lharzenetter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@salmma @mbeisel @lharzenetter