Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode should be revertable to un-set state #6

Open
davenquinn opened this issue Jun 8, 2021 · 1 comment
Open

Dark mode should be revertable to un-set state #6

davenquinn opened this issue Jun 8, 2021 · 1 comment

Comments

@davenquinn
Copy link
Member

Right now, the dark mode provider defaults to the system-configured color scheme, and uses local storage to store the configured state. Once you have configured the dark mode by clicking the button, it is in a "user-controlled" state that can't be reverted to the unaltered system-defined state. We should allow reversion of the dark mode config back to the undefined state, either by having a popover on the button, allowing a shift-click interaction, a long press, or some other means of signaling to unset the state.

@davenquinn
Copy link
Member Author

We should also allow configuring the dark mode provider NOT to use local storage if desired

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant