Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filename truncated by spaces #25

Open
ojf opened this issue Aug 30, 2017 · 3 comments
Open

filename truncated by spaces #25

ojf opened this issue Aug 30, 2017 · 3 comments
Labels

Comments

@ojf
Copy link
Member

ojf commented Aug 30, 2017

This isn't the most important bug, but it is unexpected....

Take an image with a requested name with spaces in it (on retrospect, I may not have tested only one space). Saved filename will be requested name only up to first space.

@ojf ojf added the bug label Aug 30, 2017
@tristan3214
Copy link
Contributor

In some sense that is on purpose that you shouldn't use spaces in your image names. However, the GUI doesn't handle the case where the user does input a space. There are two easy ways to fix this. Bar the user from inputting spaces, somehow. Or (I like this solution better) just replace all the white space with underscores or dashes in the name.

On the possible question of letting the user generate file names with spaces this is not possible without making some pain staking changes.

@ojf
Copy link
Member Author

ojf commented Aug 30, 2017

Well, the OS can handle filenames with spaces, but it's not conventional in unix... if it's really going to take painstaking work, then maybe we just block it somehow. Anyhoo, wanted to record this for when we finish all the higher priority work. =)

@Ssoyrnoz
Copy link
Contributor

Ssoyrnoz commented Aug 30, 2017 via email

FlameArrow57 added a commit that referenced this issue Feb 21, 2020
Spaces are now replaced with underscores.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants