Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaling-to-fit may suffer from float rounding artifacts #159

Open
sevaa opened this issue Aug 12, 2016 · 1 comment
Open

Scaling-to-fit may suffer from float rounding artifacts #159

sevaa opened this issue Aug 12, 2016 · 1 comment

Comments

@sevaa
Copy link

sevaa commented Aug 12, 2016 •
edited
Loading

Uranium has logic to scale loaded meshes to fit into the printable area (in UM/Mesh/ReadMeshJob.run(), line 74 and below). Because of floating point math being inherently imprecise, the scaled mesh may still not fit into the printable area.

Please introduce a rounding tolerance factor to account for that. Forcibly multiply the calculated scaling factor by 0.99999 or something of that nature.
@sevaa sevaa changed the title Scaling to fit subject to float rounding artifacts Scaling-to-fit may suffer from float rounding artifacts Aug 12, 2016
@Ghostkeeper
Copy link
Collaborator

Ghostkeeper commented Aug 16, 2016 •
edited
Loading

Hmm, this one again. Our internal issue tracker says this was solved back in April. Must be a regression.

We have a bugfix planned for 2.4 and a rewrite for 3.1. I'll add this bug to be planned in as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ghostkeeper @sevaa