Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future plans for the longdouble argument #297

Open
spencerkclark opened this issue Oct 8, 2022 · 2 comments
Open

Future plans for the longdouble argument #297

spencerkclark opened this issue Oct 8, 2022 · 2 comments

Comments

@spencerkclark
Copy link
Collaborator

In #284 @mcuntz added a longdouble argument to enable encoding times (in memory) with greater precision. The default was set to False, since otherwise it would interfere with serialization logic in downstream libraries (e.g. xarray). I just wanted to check if it is still planned to eventually change the default to True. In xarray this would be fairly straightforward to address by explicitly setting the longdouble argument to False in the time encoding logic, but before doing that I just wanted to confirm cftime's future plans.

@jswhit
Copy link
Collaborator

jswhit commented Oct 11, 2022

I think it would be good to change the default to True in a future release, as long as xarray supports it.

@spencerkclark
Copy link
Collaborator Author

Sounds good. I'll make that PR to xarray when I get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants