From ad720ed0417814c768a84dfde53ce3b5b6a49e17 Mon Sep 17 00:00:00 2001 From: jsy1218 <91580504+jsy1218@users.noreply.github.com> Date: Fri, 28 Feb 2025 11:47:04 -0700 Subject: [PATCH 1/2] chore: bump sor to 4.19.0 - feat: tenderly sim status TRANSFER_FROM_FAILED --- src/providers/simulation-provider.ts | 1 + src/util/tenderlySimulationErrorBreakDown.ts | 2 ++ test/unit/util/tenderlySimulationErrorBreakDown.test.ts | 7 ++++++- 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/providers/simulation-provider.ts b/src/providers/simulation-provider.ts index b2143297e..b299528a7 100644 --- a/src/providers/simulation-provider.ts +++ b/src/providers/simulation-provider.ts @@ -33,6 +33,7 @@ export enum SimulationStatus { NotApproved = 4, SystemDown = 5, SlippageTooLow = 6, + TransferFromFailed = 7, } /** diff --git a/src/util/tenderlySimulationErrorBreakDown.ts b/src/util/tenderlySimulationErrorBreakDown.ts index 9eb82a286..323d45127 100644 --- a/src/util/tenderlySimulationErrorBreakDown.ts +++ b/src/util/tenderlySimulationErrorBreakDown.ts @@ -15,6 +15,8 @@ export function breakDownTenderlySimulationError( case '0x08c379a000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000025556e697377617056323a20494e53554646494349454e545f4f55545055545f414d4f554e54000000000000000000000000000000000000000000000000000000': // INSUFFICIENT_OUTPUT_AMOUNT case '0x08c379a0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000034949410000000000000000000000000000000000000000000000000000000000': // IIA return SimulationStatus.SlippageTooLow; + case '0x08c379a0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000145452414e534645525f46524f4d5f4641494c4544000000000000000000000000': // TRANSFER_FROM_FAILED + return SimulationStatus.TransferFromFailed; case '0x675cae38': // InsufficientToken if ( tokenIn.address.toLowerCase() === diff --git a/test/unit/util/tenderlySimulationErrorBreakDown.test.ts b/test/unit/util/tenderlySimulationErrorBreakDown.test.ts index be223be84..a3f42d84f 100644 --- a/test/unit/util/tenderlySimulationErrorBreakDown.test.ts +++ b/test/unit/util/tenderlySimulationErrorBreakDown.test.ts @@ -2,11 +2,11 @@ import { breakDownTenderlySimulationError } from '../../../src/util/tenderlySimulationErrorBreakDown'; import { - SimulationStatus, USDC_MAINNET, USDT_MAINNET, VIRTUAL_BASE } from '../../../build/main'; +import { SimulationStatus } from '../../../src/providers/simulation-provider'; describe('tenderly simulation error break down', () => { it('V3TooMuchRequested', async () => { @@ -49,6 +49,11 @@ describe('tenderly simulation error break down', () => { expect(simulationStatus).toEqual(SimulationStatus.SlippageTooLow); }); + it('TRANSFER_FROM_FAILED', () => { + const simulationStatus = breakDownTenderlySimulationError(USDC_MAINNET, USDT_MAINNET, '0x08c379a0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000145452414e534645525f46524f4d5f4641494c4544000000000000000000000000'); + expect(simulationStatus).toEqual(SimulationStatus.TransferFromFailed); + }); + it('unknown data', () => { const simulationStatus = breakDownTenderlySimulationError(USDC_MAINNET, USDT_MAINNET, undefined); expect(simulationStatus).toEqual(SimulationStatus.Failed); From 3b376ac2d69a348a0c35c2da4a530a40e42bc333 Mon Sep 17 00:00:00 2001 From: jsy1218 <91580504+jsy1218@users.noreply.github.com> Date: Fri, 28 Feb 2025 11:48:42 -0700 Subject: [PATCH 2/2] 4.19.0 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 3b7c21acb..728cc6665 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@uniswap/smart-order-router", - "version": "4.18.2", + "version": "4.19.0", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@uniswap/smart-order-router", - "version": "4.18.2", + "version": "4.19.0", "license": "GPL", "dependencies": { "@eth-optimism/sdk": "^3.2.2", diff --git a/package.json b/package.json index 25c351801..7f7fdb844 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@uniswap/smart-order-router", - "version": "4.18.2", + "version": "4.19.0", "description": "Uniswap Smart Order Router", "main": "build/main/index.js", "typings": "build/main/index.d.ts",