Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x requires React 18 #151

Closed
jameshartig opened this issue Nov 15, 2023 · 1 comment · Fixed by #152
Closed

4.x requires React 18 #151

jameshartig opened this issue Nov 15, 2023 · 1 comment · Fixed by #152
Labels
bug Something isn't working

Comments

@jameshartig
Copy link
Contributor

jameshartig commented Nov 15, 2023 •
edited
Loading

Describe the bug

In #125 startTransition was used which requires React 18. The Readme makes no mention of this and only talks about Node 14 and specifically says there's no other changes.

Steps to reproduce the bug

  1. Try to compile with React 17
  2. Errors with Error: Uncaught [TypeError: i.startTransition is not a function]

Expected behavior

I expected the Readme to mention that React <18 are no longer supported.

Logs, error output, etc.

No response

Screenshots

No response

Additional context

Alternatively, it would be nice if this would still support React older than 18. For example, you could use useTransition instead to get a startTransition function.

/cc @faessler

Unleash version

No response

Subscription type

None

Hosting type

None

SDK information (language and version)

No response
@jameshartig jameshartig added the bug Something isn't working label Nov 15, 2023
@jameshartig jameshartig changed the title 4.0.0 requires React 18 4.x requires React 18 Nov 15, 2023
@nunogois
Copy link
Member

Hi @jameshartig, thank you for opening this issue, nice catch!
It seems like you already have a good solution for this. Would you like to open a PR with your suggestion or do you prefer we handle it?

Thanks 🙂

jameshartig added a commit to jameshartig/proxy-client-react that referenced this issue Nov 16, 2023
@jameshartig
fix: fallback for startTransition for React <18
996e756 
Fixes Unleash#151
@jameshartig jameshartig mentioned this issue Nov 16, 2023
Merged
@github-project-automation github-project-automation bot moved this from New to Done in Issues and PRs Nov 27, 2023
Tymek pushed a commit that referenced this issue Nov 27, 2023
@jameshartig
fix: fallback for startTransition for React <18 (#152)
8813e5b 
Fixes #151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fallback for startTransition for React <18 jameshartig/proxy-client-react
2 participants
@jameshartig @nunogois