Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CurrentTime to createRequestParameters #160

Closed
AdrienFromToulouse opened this issue Jan 24, 2024 · 5 comments
Closed

Add CurrentTime to createRequestParameters #160

AdrienFromToulouse opened this issue Jan 24, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@AdrienFromToulouse
Copy link

Describe the feature request

Hi,

Following Unleash/unleash-proxy-client-js#195 and Unleash/proxy-client-react#158 I think we should also have the CurrentTime prop available here? https://github.com/Unleash/unleash-proxy/blob/main/src/unleash-proxy.ts#L79-L84

Cheers,

Background

No response

Solution suggestions

No response

@sighphyre
Copy link
Member

Hey, thanks, good catch. This probably should be in here. I'll patch this in the next few days

Just a warning, this project is approaching end of life. We strongly recommend using Unleash Edge instead

@AdrienFromToulouse
Copy link
Author

oh was not aware of Unleash edge. Thank you for the upcoming update, in the meantime we will plan a rollout out of Unleash edge I guess.

@sighphyre
Copy link
Member

@AdrienFromToulouse It's not urgent to upgrade, the Proxy will be around for a long, long time. Probably at some point this year we'll formally mark this project as hitting EOL, but that will mostly just mean we won't add new features, we'll continue to do bugfixes and security updates as needed

We've released v1.1.0 of the Proxy, which should now accept current time

@github-project-automation github-project-automation bot moved this from New to Done in Issues and PRs Jan 26, 2024
@AdrienFromToulouse
Copy link
Author

AdrienFromToulouse commented Jan 26, 2024

@AdrienFromToulouse It's not urgent to upgrade, the Proxy will be around for a long, long time. Probably at some point this year we'll formally mark this project as hitting EOL, but that will mostly just mean we won't add new features, we'll continue to do bugfixes and security updates as needed

We've released v1.1.0 of the Proxy, which should now accept current time

@sighphyre sweeeeeet. Thank you so much for the quick update ❤️ really appreciate.

@sighphyre
Copy link
Member

Nothing but a pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants