From cf1da076109503695e0e5ad3dcde0b949f690273 Mon Sep 17 00:00:00 2001 From: sjaanus Date: Tue, 17 Dec 2024 10:45:36 +0200 Subject: [PATCH] Fix --- .../delta/client-feature-toggle-delta.ts | 6 +++++- .../tests/client-feature-toggles.e2e.test.ts | 18 ------------------ 2 files changed, 5 insertions(+), 19 deletions(-) diff --git a/src/lib/features/client-feature-toggles/delta/client-feature-toggle-delta.ts b/src/lib/features/client-feature-toggles/delta/client-feature-toggle-delta.ts index 0a22186141c6..271221426dba 100644 --- a/src/lib/features/client-feature-toggles/delta/client-feature-toggle-delta.ts +++ b/src/lib/features/client-feature-toggles/delta/client-feature-toggle-delta.ts @@ -99,7 +99,7 @@ export class ClientFeatureToggleDelta { private delta: Revisions = {}; - private segments: IClientSegment[] = []; + private segments: IClientSegment[]; private eventStore: IEventStore; @@ -156,6 +156,10 @@ export class ClientFeatureToggleDelta { if (!hasDelta) { await this.initEnvironmentDelta(environment); } + const hasSegments = this.segments; + if (!hasSegments) { + await this.updateSegments(); + } // Should get the latest state if revision does not exist or if sdkRevision is not present // We should be able to do this without going to the database by merging revisions from the delta with diff --git a/src/lib/features/client-feature-toggles/tests/client-feature-toggles.e2e.test.ts b/src/lib/features/client-feature-toggles/tests/client-feature-toggles.e2e.test.ts index 3826716f1353..5e9a608c6c3a 100644 --- a/src/lib/features/client-feature-toggles/tests/client-feature-toggles.e2e.test.ts +++ b/src/lib/features/client-feature-toggles/tests/client-feature-toggles.e2e.test.ts @@ -346,21 +346,3 @@ test('should match snapshot from /api/client/features', async () => { expect(result.body).toMatchSnapshot(); }); - -test('should match with /api/client/delta', async () => { - await setupFeatures(db, app); - - const { body } = await app.request - .get('/api/client/features') - .set('Unleash-Client-Spec', '4.2.0') - .expect('Content-Type', /json/) - .expect(200); - - const { body: deltaBody } = await app.request - .get('/api/client/delta') - .expect('Content-Type', /json/) - .expect(200); - - expect(body.features).toMatchObject(deltaBody.updated); - expect(body.segments).toMatchObject(deltaBody.segments); -});