Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN error #271

Open
mpadge opened this issue Feb 16, 2025 · 1 comment
Open

CRAN error #271

mpadge opened this issue Feb 16, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@mpadge
Copy link
Member

mpadge commented Feb 16, 2025

https://cran.r-project.org/web/checks/check_results_dodgr.html

Lots of sudden failures, all of which are:

 ══ Failed tests ════════════════════════════════════════════════════════════════
  ── Failure ('test-dists-categorical.R:12:5'): categorical dists ────────────────
  `graph <- weight_streetnet(hampi)` produced messages.
  ── Failure ('test-dists-categorical.R:97:5'): categorical dists summary ────────
  `graph <- weight_streetnet(hampi)` produced messages.
  ── Failure ('test-dists-categorical.R:116:5'): proportions only ────────────────
  `graph <- weight_streetnet(hampi)` produced messages.
  ── Failure ('test-dists-categorical.R:144:5'): categorical threshold ───────────
  `graph <- weight_streetnet(hampi)` produced messages.
  ── Failure ('test-dists-categorical.R:166:5'): categorical pairwise ────────────
  `graph <- weight_streetnet(hampi)` produced messages.
  ── Failure ('test-dists-nearest.R:10:5'): categorical nearest dists ────────────
  `graph <- weight_streetnet(hampi)` produced messages.
  ── Failure ('test-dists.R:11:5'): dists ────────────────────────────────────────
  `graph <- weight_streetnet(hampi)` produced messages.
  ── Failure ('test-dists.R:79:5'): dists-pairwise ───────────────────────────────
  `graph <- weight_streetnet(hampi)` produced messages.
  ── Failure ('test-dists.R:328:5'): graph columns ───────────────────────────────
  `graph <- weight_streetnet(hampi)` produced messages.
  ── Failure ('test-dists.R:351:5'): graph columns ───────────────────────────────
  `graph <- weight_streetnet(hampi)` produced messages.
  ── Failure ('test-dists.R:358:5'): negative weights ────────────────────────────
  `graph <- weight_streetnet(hampi)` produced messages.
  ── Failure ('test-iso.R:17:5'): isodists ───────────────────────────────────────
  Expected `net <- weight_streetnet(hsc, wt_profile = "bicycle")` to run without any messages.
  ℹ Actually got a <simpleMessage> with text:
    Superclass process has cloneable=FALSE, but subclass r_process has cloneable=TRUE. A subclass cannot be cloneable when its superclass is not cloneable, so cloning will be disabled for r_process.
    
  ── Error ('test-iso.R:22:5'): isodists ─────────────────────────────────────────
  Error in `eval(code, test_env)`: object 'net' not found
  Backtrace:
      ▆
   1. └─base::sample(net$.vx0, size = npts) at test-iso.R:22:5
@mpadge mpadge added the bug Something isn't working label Feb 16, 2025
@mpadge
Copy link
Member Author

mpadge commented Feb 16, 2025

r-lib/callr#284, but easy enough to fix here regardless by removing test expectations

mpadge added a commit that referenced this issue Feb 16, 2025
mpadge added a commit that referenced this issue Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant