-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to wallet connect 2.0 providers #64
Comments
Hey @danibonilha ! Thanks a lot for this issue and the informations :) It is quite a busy week on my side, I'm gonna try to have a look this week-end! |
Hey @danibonilha! I started to take a look at migration to V2 of WalletConnect, as I understand from their docs, the migration path in the case of the previous package Are you using this I started to implement the mock for the Ethereum Provider, I have some issue as I did not succeed to connect to any of my 5 or 6 wallets using WalletConnect V2 for now but I'll keep trying 😅. Anyway if you use the UniversalProvider directly, there is probably a way to also expose a mock for that. |
Hi @VGLoic thanks for taking a look at it. We were using |
Nice, thanks a lot! It will help me :) Sorry if this takes me a bit of time, I'm tackling it as fast as I can 😬 |
Hey @danibonilha ! This issue is giving me a hard time ahah I have not been able to find a wallet supporting Wallet Connect V2, I tried Rainbow, MetaMask Mobile, Trust Wallet and Argent Wallet I think but without luck. I tried on their live demo app. If you have any wallet and/or code example working, I'll be more than happy 😂 Also, on the test side, jest has hard time dealing with some deep CommonJS dependency of the I'll continue digging on that of course :) |
Hi @VGLoic that's unfortunate 🥲 Hope it helps! |
Hey! Small update, so there is currently an issue between one of the dependency of Universal Provider and Jest, the related issue is WalletConnect/walletconnect-monorepo#1749 At least there is an issue that I can follow now and I'll try the temporary fixes for it, keeping you updated! |
Hey @danibonilha! Very sorry for the late message! I unfortunately did not take the time to work on this issue and I will no longer maintain this repository. Thanks again for the time you took on this issue and to have used this package. Have a great day! |
What is the new or updated feature that you are suggesting?
Wallet connect launched version 2.0 and it has breaking changes regarding providers, there are a couple of new providers and they recommend the usage of this UniversalProvider. The project I'm working on has already started the migration but the tests are failing due to incompatible providers.
Why should this feature be included?
Wallet connect v1.0 will sunset soon as stated in this post, which will force all users to update to next version.
The text was updated successfully, but these errors were encountered: