Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to wallet connect 2.0 providers #64

Closed
danibonilha opened this issue Jan 31, 2023 · 8 comments · May be fixed by #65
Closed

Add support to wallet connect 2.0 providers #64

danibonilha opened this issue Jan 31, 2023 · 8 comments · May be fixed by #65

Comments

@danibonilha
Copy link

What is the new or updated feature that you are suggesting?

Wallet connect launched version 2.0 and it has breaking changes regarding providers, there are a couple of new providers and they recommend the usage of this UniversalProvider. The project I'm working on has already started the migration but the tests are failing due to incompatible providers.

Why should this feature be included?

Wallet connect v1.0 will sunset soon as stated in this post, which will force all users to update to next version.

@VGLoic
Copy link
Owner

VGLoic commented Jan 31, 2023

Hey @danibonilha ! Thanks a lot for this issue and the informations :)

It is quite a busy week on my side, I'm gonna try to have a look this week-end!

@VGLoic
Copy link
Owner

VGLoic commented Feb 5, 2023

Hey @danibonilha! I started to take a look at migration to V2 of WalletConnect, as I understand from their docs, the migration path in the case of the previous package @walletconnect/web3-provider is to go to @walletconnect/ethereum-provider

Are you using this EthereumProvider or are you using the underlying UniversalProvider? :)

I started to implement the mock for the Ethereum Provider, I have some issue as I did not succeed to connect to any of my 5 or 6 wallets using WalletConnect V2 for now but I'll keep trying 😅. Anyway if you use the UniversalProvider directly, there is probably a way to also expose a mock for that.

@danibonilha
Copy link
Author

Hi @VGLoic thanks for taking a look at it. We were using web3-provider, but then we've replaced web3 with ethers. The wallet connect team has this example Dapp with ethers which they use/recommend the UniversalProvider. My hunch is that it would be nice to support both EthereumProvider and UniversalProvider. But In our project we are using UniversalProvider only.
Here they have more dapps and wallets examples, I hope it's helpful.

@VGLoic
Copy link
Owner

VGLoic commented Feb 6, 2023

Nice, thanks a lot! It will help me :)

Sorry if this takes me a bit of time, I'm tackling it as fast as I can 😬

@VGLoic
Copy link
Owner

VGLoic commented Feb 12, 2023

Hey @danibonilha !

This issue is giving me a hard time ahah

I have not been able to find a wallet supporting Wallet Connect V2, I tried Rainbow, MetaMask Mobile, Trust Wallet and Argent Wallet I think but without luck. I tried on their live demo app. If you have any wallet and/or code example working, I'll be more than happy 😂

Also, on the test side, jest has hard time dealing with some deep CommonJS dependency of the Universal Provider 😓

I'll continue digging on that of course :)

@danibonilha
Copy link
Author

Hi @VGLoic that's unfortunate 🥲
Cardstack wallet supports WC V2 here's the code and it's available to be downloaded on mobile app stores, also Wallet Connect has an example wallet that you can find it here. As far as an example with universal provider, I have this PR open.

Hope it helps!

@VGLoic
Copy link
Owner

VGLoic commented Feb 19, 2023

Hey! Small update, so there is currently an issue between one of the dependency of Universal Provider and Jest, the related issue is WalletConnect/walletconnect-monorepo#1749

At least there is an issue that I can follow now and I'll try the temporary fixes for it, keeping you updated!

@VGLoic
Copy link
Owner

VGLoic commented Oct 7, 2024

Hey @danibonilha!

Very sorry for the late message!

I unfortunately did not take the time to work on this issue and I will no longer maintain this repository.

Thanks again for the time you took on this issue and to have used this package.

Have a great day!

@VGLoic VGLoic closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants