Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] / [MORE PRIMITIVES] Enricher's aggregators are too simple! #10

Open
4 of 5 tasks
simonprovost opened this issue Feb 26, 2025 · 0 comments
Open
4 of 5 tasks
Assignees

Comments

@simonprovost
Copy link
Collaborator

💡 Feature Request

Welcome to the OSMNxMapping feature request hub! 🎉

Hey there, before you jump in, take a quick sec to check out the
important stuff below—it’ll help us keep the magic flowing smoothly.

Important

Before you proceed, please confirm the following:

  • I’ve checked the API docs and confirmed this feature doesn’t already exist (no duplicates, please!).
  • I’ve scoured the existing issues to make sure this hasn’t been requested before.
  • I get that feature requests are reviewed periodically and might take a little time—patience is key!

Describe the Feature Request

The current enricher's aggregators (e.g. .aggregate_with(), .count_by) could be deserving more, from basic to advanced aggregators to broaden the possibilities of enrichments.

An aggregator should be inherited from: https://github.com/VIDA-NYU/OSMNXMapping/blob/main/src/osmnx_mapping/modules/enricher/aggregator/abc_aggregator.py

Describe Preferred Solution

N/A

Describe Alternatives

N/A

Related Code

N/A

Additional Context

N/A

If the feature request is approved, would you be willing to submit a PR?

  • Yes
  • No

(No worries if you’re new to this—we’ll guide you every step of the way! 🤝)

@simonprovost simonprovost self-assigned this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant