Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing server address breaks current session, requires restart #888

Open
VMelnalksnis opened this issue Jul 4, 2023 · 1 comment
Open

Changing server address breaks current session, requires restart #888

VMelnalksnis opened this issue Jul 4, 2023 · 1 comment
Labels
area:ui Relating to user interface type:bug Something isn't working

Comments

@VMelnalksnis
Copy link
Owner

Describe the bug
Changing the server address after logging in has no effect, and requires a restart to apply.

To Reproduce
Steps to reproduce the behavior:

  1. Open Gnomeshade, log in
  2. Go to 'Settings' and update the server address
  3. Log out
  4. Try to log in to the new server
  5. See that requests are sent to the old server

Expected behavior
Either configuration changes are applied, or the user is notified that a restart is required.
@VMelnalksnis VMelnalksnis added type:bug Something isn't working area:ui Relating to user interface labels Jul 4, 2023
@VMelnalksnis
Copy link
Owner Author

The naive approach of just updating HttpClient.BaseAddress on configuration change does not work, because it cannot be updated after a request is sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:ui Relating to user interface type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@VMelnalksnis