Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blitz v2 follow-on issues #217

Closed
Vandivier opened this issue May 8, 2024 · 9 comments
Closed

blitz v2 follow-on issues #217

Vandivier opened this issue May 8, 2024 · 9 comments

Comments

@Vandivier
Copy link
Owner

#189 incurred some tech debt which isn't necessarily high priority. probable seo and performance improvements from solving these, i'm not immediately sure of magnitudes. here are the tasks:

  1. audit cases of "use client" and basically use it less often
  2. ensure metadata is properly exported and proper SEO is occurring
@Vandivier
Copy link
Owner Author

fix prettier integration for local dev

@Vandivier
Copy link
Owner Author

use new layout, similar to create-next-app layout file, not old Layout.tsx

@Vandivier
Copy link
Owner Author

also, about typed routes:
blitz-js/blitz#4306

@Vandivier
Copy link
Owner Author

import { useRouter } from "next/compat/router"

the place we use that (within layout file) needs to be updated so that we don't make all pages use client

we can accomplish canonical identification at build time by other means, such as by exporting SEO meta per-page

@Vandivier
Copy link
Owner Author

  1. reconcile duplicate layout.tsx files and other duplicate components
  2. less "use client"
  3. don't import { useRouter } from "next/compat/router"
  4. use new site meta / page meta pattern instead of Head tag in layout file(s)
  5. make sure sitemap works

@Vandivier
Copy link
Owner Author

@Vandivier
Copy link
Owner Author

there's some flash of undesirable content on /signup and maybe some other pages

@Vandivier
Copy link
Owner Author

"Loading..." flash is ick
We shouldn't need "use client" on every page due to menu login state detection
layout can be updated not to useRouter and to require slug

@Vandivier
Copy link
Owner Author

closing bc we will just use t3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant