-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vesktop streams resolution of source window no matter what #463
Comments
I found that for some reason, framerate takes directly from mediaDevices.getDisplayMedia (which returns MediaStream) object.
In code above, there are also tries to set custom resolution but without success (even if these constraints applying works in local WebRTC share-show demo) But for me, the main complexity is that I do not know how to pass screenShare.ts's choice StreamPick object with resolution and fps that user chose to screenShareAudio.ts file, so I believe that someone who knows this project and TypeScript better can deal with it. |
Closed by #489. |
Describe the bug
When screen sharing Vesktop will ignore your prefered resolution and use the resolution of the display/app you are using. I confirmed this with a friend and they are receiving a full 4K stream even tho discord reports that I chose 720p for both of us.
To Reproduce
Voice Connected
in the bottom left cornerDebug
RTC DEBUG: STREAM
there will be a tab namedOutbound
go thereResolution
reported thereExpected behavior
scale video to 720p during encode
Screenshots
I am streaming the file explorer window behind the debug window. it is in one corner of my 4K monitor and I chose to stream in discord at 480p:
Desktop (please complete the following information):
Command line output
nothing to really note
Additional context
The text was updated successfully, but these errors were encountered: