Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to other languages #9

Open
akalicki opened this issue Jul 22, 2013 · 37 comments
Open

Port to other languages #9

akalicki opened this issue Jul 22, 2013 · 37 comments

Comments

@akalicki
Copy link
Contributor

Given the relatively small size of the VerbalExpression class and its general usefulness I feel it would be easy and helpful to port it to other languages. I see that @putneyj is working on a Java version, and I'd be willing to port it to C++ / PHP as well if you think it's a good idea.

@crawfordcomeaux
Copy link
Contributor

I say go for it!

@AmeenAhmed
Copy link

+1

@ghost
Copy link

ghost commented Jul 22, 2013

I might have a crack at porting it to Python tonight. I need an excuse to get some practice in on it.

@mihai-vlc
Copy link
Contributor

great idea i will do the php port today

@MaciejLisCK
Copy link

Cool I am going for C# port :)

@ryan-endacott
Copy link
Member

I'll try and port it to Ruby tonight :)

@markwilson
Copy link

I started working on a PHP port earlier today - https://github.com/MarkWilson/VerbalExpressionsPhp

@mihai-vlc
Copy link
Contributor

we all ported it in about the same time 😸 , it doesn't matter it was a good practice anyway 😄
https://github.com/ionutvmi/VerbalExpressions

@zbma
Copy link

zbma commented Jul 22, 2013

I like the idea. Early C# version can be found here VerbalExpressionsSharp, though I need to work on it.

@akalicki
Copy link
Contributor Author

Thanks everyone for the support! The one thing I'm worried about is code fragmentation - since each adaptation is just a single file it's probably best to keep all versions in one place for easy download and editing. When you guys are done with your language ports would you mind forking the original project and submitting a pull request with just the VerbalExpressions file so we can keep them all in this repository?

@jehna
Copy link
Contributor

jehna commented Jul 22, 2013

akalicki I like your idea. I'd be glad to add you as collaborators for each language on the same repository to keep the code in one place. Go ahead and kick in your pull requests.

@ryan-endacott
Copy link
Member

Started the ruby port, it's not quite done yet though: https://github.com/ryan-endacott/VerbalExpressions.rb

@ghost
Copy link

ghost commented Jul 22, 2013

My python port sorta kinda works. I'll finish it off in a couple of days.

@crawfordcomeaux
Copy link
Contributor

Is it premature to start pushing for porting with package management systems?

Disclaimer: I'm not familiar with the process of packaging libraries for things like pip, rubygems, npm, etc.—
Sent from Mailbox for iPhone, suckah!

On Mon, Jul 22, 2013 at 6:48 PM, Jake Adams [email protected]
wrote:

My python port sorta kinda works. I'll finish it off in a couple of days.

Reply to this email directly or view it on GitHub:
#9 (comment)

@go-oleg
Copy link
Member

go-oleg commented Jul 23, 2013

@akalicki , @jehna ,

Perhaps it would be a good idea to create an organization and create a separate repo for each language with one central repo containing the documentation/API?

As more languages get added, it'll be harder to keep all of them in sync and filing bugs or enhancement requests against a specific language may get convoluted. Also, any unit tests would also be language-specific, so suddenly theres going to be more than one file associated with each language.

Just some thoughts.

-Oleg

@crawfordcomeaux
Copy link
Contributor

+1

Sent from Mailbox for iPhone, suckah!

On Mon, Jul 22, 2013 at 10:31 PM, Oleg Seletsky [email protected]
wrote:

@akalicki , @jehna ,
Perhaps it would be a good idea to create an organization and create a separate repo for each language with one central repo containing the documentation/API?
As more languages get added, it'll be harder to keep all of them in sync and filing bugs or enhancement requests against a specific language may get convoluted. Also, any unit tests would also be language-specific, so suddenly theres going to be more than one file associated with each language.
Just some thoughts.

-Oleg

Reply to this email directly or view it on GitHub:
#9 (comment)

@ryan-endacott
Copy link
Member

@go-oleg, I think that's a good idea. With my Ruby port, I already have tests, a rakefile, and a gemspec. I'm not sure all of that belongs in this repo.

We could also make this repo a central one without any specific implementation. It could just have some code examples and then link to all of other repos.

@mihai-vlc
Copy link
Contributor

@go-oleg yes you are right we should link to each other in the readme file that way we can keep things organized for bugs and language specific features

@zbma
Copy link

zbma commented Jul 23, 2013

I have more than one file (interface, class, extension class, tests, project files). Reasons mentioned by @ionutvmi sounds good too. So I like @go-oleg idea.

@jameshalsall
Copy link

There's a PHP composer ready port of this library here https://github.com/markwilson/VerbalExpressionsPhp

@jehna
Copy link
Contributor

jehna commented Jul 24, 2013

@go-oleg @ryan-endacott @walkhard this project has indeed grown out of one repository's boundaries. That's why I've made you collaborators, and all help would be greatly appreciated to get this project back in order.

And yes, +1 for @go-oleg idea of making VerbalExpressions into an organization.

@mihai-vlc
Copy link
Contributor

I went ahead and made an organisation here https://github.com/VerbalExpressions , i added @jehna as owner and we should add all the users to transfer their ported versions there to have them in one place.

@ryan-endacott
Copy link
Member

@ionutvmi, add me and I'll fork my Ruby port.

@sergeyklay
Copy link

@ionutvmi good idea :octocat:

@ryan-endacott
Copy link
Member

@ionutvmi @jehna Should we go ahead and make this repository (because it's so popular) a general readme Repo that gives an example and links to the organization?

@ryan-endacott
Copy link
Member

@ionutvmi, it actually looks like even though I'm a member I don't have permission to fork. Here's the Ruby port if you want to fork it.

@mihai-vlc
Copy link
Contributor

@ryan-endacott i have forked it you should be able to push and pull in that forked version now.

@ryan-endacott
Copy link
Member

@ionutvmi, Awesome! Thanks.

@jehna, could you add a link in the description of this repo to the organization?

@maxsz
Copy link

maxsz commented Aug 7, 2013

Hey, just wanted to let you know that I started with an Elixir port. It's far from complete, just wanted to leave a note in case someone else is interested in this.

@jehna Great idea and great library!

@rajatkhanduja
Copy link

This is a brilliant idea to make regular expressions much more readable and easy to use! I would like to try to build this for OCaml (since other languages that I felt comfortable with have already been taken care of :P ). I won't commit to it yet, though, since I am not so sure if I'd be able to manage it! But if anyone's already working on OCaml port of this, I'd be glad to help out!

@lanwen
Copy link

lanwen commented May 5, 2014

Hello!
Can you give me rights in https://github.com/VerbalExpressions/JavaVerbalExpressions
Because no one maintains this port over 6 months and i can do it.

I've already upload fork in maven central https://github.com/lanwen/java-verbal-expressions and want to merge info to main repo.

@jehna
Copy link
Contributor

jehna commented May 5, 2014

@lanwen you should now have push&pull rights to the repo. A big thank you for taking over the maintenance!

@dzenbot
Copy link

dzenbot commented Jan 6, 2016

I totally see this been useful in Swift and/or Objective-C!

@dzenbot
Copy link

dzenbot commented Jan 6, 2016

nvm my last comment, it's done already 😅

@tylerlittlefield
Copy link
Member

I wanted to submit a port for R: https://github.com/tyluRp/RVerbalExpressions

It's not entirely complete yet, see here. Hoping to wrap everything up by the end of the weekend.

How does "submitting" a port work? Do I request to be a member and transfer ownership?

@mihai-vlc
Copy link
Contributor

Hi @tyluRp ,

I have added you to the organization.
You should be able to perform the repository transfer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests