-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to other languages #9
Comments
I say go for it! |
+1 |
I might have a crack at porting it to Python tonight. I need an excuse to get some practice in on it. |
great idea i will do the php port today |
Cool I am going for C# port :) |
I'll try and port it to Ruby tonight :) |
I started working on a PHP port earlier today - https://github.com/MarkWilson/VerbalExpressionsPhp |
we all ported it in about the same time 😸 , it doesn't matter it was a good practice anyway 😄 |
I like the idea. Early C# version can be found here VerbalExpressionsSharp, though I need to work on it. |
Thanks everyone for the support! The one thing I'm worried about is code fragmentation - since each adaptation is just a single file it's probably best to keep all versions in one place for easy download and editing. When you guys are done with your language ports would you mind forking the original project and submitting a pull request with just the VerbalExpressions file so we can keep them all in this repository? |
akalicki I like your idea. I'd be glad to add you as collaborators for each language on the same repository to keep the code in one place. Go ahead and kick in your pull requests. |
Started the ruby port, it's not quite done yet though: https://github.com/ryan-endacott/VerbalExpressions.rb |
My python port sorta kinda works. I'll finish it off in a couple of days. |
Is it premature to start pushing for porting with package management systems? Disclaimer: I'm not familiar with the process of packaging libraries for things like pip, rubygems, npm, etc.— On Mon, Jul 22, 2013 at 6:48 PM, Jake Adams [email protected]
|
Perhaps it would be a good idea to create an organization and create a separate repo for each language with one central repo containing the documentation/API? As more languages get added, it'll be harder to keep all of them in sync and filing bugs or enhancement requests against a specific language may get convoluted. Also, any unit tests would also be language-specific, so suddenly theres going to be more than one file associated with each language. Just some thoughts. -Oleg |
+1 On Mon, Jul 22, 2013 at 10:31 PM, Oleg Seletsky [email protected]
|
@go-oleg, I think that's a good idea. With my Ruby port, I already have tests, a rakefile, and a gemspec. I'm not sure all of that belongs in this repo. We could also make this repo a central one without any specific implementation. It could just have some code examples and then link to all of other repos. |
@go-oleg yes you are right we should link to each other in the readme file that way we can keep things organized for bugs and language specific features |
There's a PHP composer ready port of this library here https://github.com/markwilson/VerbalExpressionsPhp |
@go-oleg @ryan-endacott @walkhard this project has indeed grown out of one repository's boundaries. That's why I've made you collaborators, and all help would be greatly appreciated to get this project back in order. And yes, +1 for @go-oleg idea of making VerbalExpressions into an organization. |
I went ahead and made an organisation here https://github.com/VerbalExpressions , i added @jehna as owner and we should add all the users to transfer their ported versions there to have them in one place. |
@ionutvmi, add me and I'll fork my Ruby port. |
@ionutvmi good idea |
@ryan-endacott i have forked it you should be able to push and pull in that forked version now. |
This is a brilliant idea to make regular expressions much more readable and easy to use! I would like to try to build this for OCaml (since other languages that I felt comfortable with have already been taken care of :P ). I won't commit to it yet, though, since I am not so sure if I'd be able to manage it! But if anyone's already working on OCaml port of this, I'd be glad to help out! |
Hello! I've already upload fork in maven central https://github.com/lanwen/java-verbal-expressions and want to merge info to main repo. |
@lanwen you should now have push&pull rights to the repo. A big thank you for taking over the maintenance! |
I totally see this been useful in Swift and/or Objective-C! |
nvm my last comment, it's done already 😅 |
I wanted to submit a port for It's not entirely complete yet, see here. Hoping to wrap everything up by the end of the weekend. How does "submitting" a port work? Do I request to be a member and transfer ownership? |
Hi @tyluRp , I have added you to the organization. |
Given the relatively small size of the VerbalExpression class and its general usefulness I feel it would be easy and helpful to port it to other languages. I see that @putneyj is working on a Java version, and I'd be willing to port it to C++ / PHP as well if you think it's a good idea.
The text was updated successfully, but these errors were encountered: