Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TsInterface should not have exported static members #24

Open
vegegoku opened this issue Feb 13, 2023 · 1 comment
Open

TsInterface should not have exported static members #24

vegegoku opened this issue Feb 13, 2023 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@vegegoku
Copy link
Member

vegegoku commented Feb 13, 2023

For example the following java class

@TsInterface
@TsName(namespace = "dh")
public class HasEventHandling {

    @JsProperty(namespace = "dh.Client")
    public static final String EVENT_REQUEST_FAILED = "requestfailed";
    
}

will produce the following TS

export namespace dh {

   export interface HasEventHandling {

      get EVENT_REQUEST_FAILED():string;

   }
 
}

we need to error out for TsInterface static members.

@vegegoku vegegoku added the bug Something isn't working label Feb 13, 2023
@vegegoku vegegoku added this to the 1.1 milestone Feb 13, 2023
@vegegoku vegegoku self-assigned this Feb 13, 2023
@niloc132
Copy link
Member

Note that this might be related to the attempt to export the property to a different type, which we've agreed should be forbidden (at least for now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants