Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halo 3 Animations Bug #18

Open
SonicPrimus opened this issue Nov 14, 2021 · 4 comments
Open

Halo 3 Animations Bug #18

SonicPrimus opened this issue Nov 14, 2021 · 4 comments
Labels
Third-party addons involved Issues involving other addons Visual errors/weirdness Anything that doesn't look right/correct

Comments

@SonicPrimus
Copy link

This is an issue I discovered when using a mod that adds animations from Halo 3 to certain playermodels. Here is an image that can hopefully explain this in a nutshell. Can this be fixed in the future?

@VickyFrenzy
Copy link
Owner

This is due to the way the addon "mask away" limbs.
I already had ideas on how to improve this but I don't really have any free available time to really look into this.

@SonicPrimus
Copy link
Author

Oh! What kind of ideas did you have? Perhaps they can be implemented by another party?

@VickyFrenzy
Copy link
Owner

VickyFrenzy commented Nov 14, 2021

Oh! What kind of ideas did you have?

My first idea was to try to set up some sort of configurable culling instead of moving the bones around...
Like a player being able to tweak what the addon should mask about their current playermodel.
This can take a long time to implement as the addon isn't design for this but it would be a massive quality of life improvement.
I even imagined the ability to submit curated presets for playermodels.

Perhaps they can be implemented by another party?

Of course!
Like I said in the addon description and README, pull request are welcome.
I will always take time to test and accept community contributions that fixes issues with the addon or improve it.

@SonicPrimus
Copy link
Author

This is great to hear! I'm very glad this addon can get the improvements it needs. This can also be greatly beneficial for PMs with other animations like ones tied to the Doom Slayer or character models like the Sanghelli (Elites) from Halo. Obviously this also goes for the H3 animations I just mentioned that are currently being used for the Halo Infinite Master Chief Player model used in the screenshot. I'm glad I was able to bring this to your attention.

@VickyFrenzy VickyFrenzy added Visual errors/weirdness Anything that doesn't look right/correct Third-party addons involved Issues involving other addons and removed bug labels Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Third-party addons involved Issues involving other addons Visual errors/weirdness Anything that doesn't look right/correct
Projects
None yet
Development

No branches or pull requests

2 participants