From 523dc424db3477f9c903b156e875774a869b4877 Mon Sep 17 00:00:00 2001
From: Victor Winberg <victor.m.winberg@gmail.com>
Date: Mon, 19 Aug 2024 08:41:43 +0200
Subject: [PATCH] camera id to database

---
 client/src/components/QRScanner.vue        | 30 ++++++-------------
 client/src/components/UserSettings.vue     | 35 +++++++++++++++++++---
 client/src/locales/en.json                 |  1 +
 client/src/locales/sv.json                 |  1 +
 server/migrations/20240819-user-camera.sql |  2 ++
 server/schema.sql                          |  1 +
 server/src/user/user-model.js              |  4 +--
 7 files changed, 47 insertions(+), 27 deletions(-)
 create mode 100644 server/migrations/20240819-user-camera.sql

diff --git a/client/src/components/QRScanner.vue b/client/src/components/QRScanner.vue
index 94fa814a..00d01484 100644
--- a/client/src/components/QRScanner.vue
+++ b/client/src/components/QRScanner.vue
@@ -1,7 +1,7 @@
 <template>
   <div class="qr-scanner-wrapper">
     <div class="qr-scanner">
-      <div class="qr-scanner__camera" @click="nextCamera">
+      <div class="qr-scanner__camera">
         <i class="fas fa-camera-retro"></i>
         {{ $t("scanner.title") }}
       </div>
@@ -32,11 +32,13 @@ export default Vue.extend({
       flashOn: false,
       scanner: undefined,
       timeout: -1,
-      timeoutMs: 10 * 1000,
-      cameraIndex: 0
+      timeoutMs: 10 * 1000
     };
   },
-  computed: mapState("scan", ["scanning"]),
+  computed: {
+    ...mapState("scan", ["scanning"]),
+    ...mapState("user", ["user"])
+  },
   created() {
     const { query } = this.$route;
     if (this.$route.path !== "/") this.$router.push({ path: "/", query });
@@ -65,18 +67,10 @@ export default Vue.extend({
     ...mapMutations("scan", ["stopScan"]),
     ...mapActions("scan", ["handleQR"]),
     async initScanner() {
-      await navigator.mediaDevices.getUserMedia({
-        audio: false,
-        video: {
-          facingMode: { ideal: "environment" },
-          aspectRatio: { ideal: 1.7777777778 },
-          frameRate: { ideal: 60, min: 30 },
-          zoom: 1
-        }
-      });
+      await navigator.mediaDevices.getUserMedia({ audio: false, video: true });
       const devices = await navigator.mediaDevices.enumerateDevices();
       const cameras = devices.filter(device => device.kind === "videoinput");
-      const { deviceId } = cameras[this.cameraIndex % cameras.length];
+      const { deviceId } = cameras[(this.user.cameraId || 0) % cameras.length];
       const { qrscan } = this.$refs;
       if (!deviceId || !qrscan) return;
 
@@ -91,7 +85,7 @@ export default Vue.extend({
         },
         QRScanner._onDecodeError,
         QRScanner._calculateScanRegion,
-        "755A2BC07E2D6465D7B5E90BD152774DAC384FEE"
+        deviceId
       );
       await this.scanner.start();
       this.hasFlash = await this.scanner.hasFlash();
@@ -105,12 +99,6 @@ export default Vue.extend({
       if (!this.scanner) return;
       await this.scanner.toggleFlash();
       this.flashOn = !this.flashOn;
-    },
-    async nextCamera() {
-      if (!this.scanner) return;
-      this.cameraIndex++;
-      await this.scanner.stop();
-      await this.initScanner();
     }
   }
 });
diff --git a/client/src/components/UserSettings.vue b/client/src/components/UserSettings.vue
index 6a5b9fd9..d20826ee 100644
--- a/client/src/components/UserSettings.vue
+++ b/client/src/components/UserSettings.vue
@@ -24,6 +24,23 @@
         </select>
       </div>
 
+      <div class="select-camera" @click="getCameras">
+        {{ $t("settings.camera-option") }}
+        <select
+          :key="cameras.length"
+          :value="user.cameraId"
+          @change="setCamera"
+        >
+          <option
+            v-for="(camera, i) in cameras"
+            :key="`camera-${i}`"
+            :value="i"
+          >
+            {{ camera.label }}
+          </option>
+        </select>
+      </div>
+
       <a href="/auth/logout" class="log-out">
         {{ $t("settings.logout-option") }}
       </a>
@@ -43,7 +60,8 @@ import { languages } from "../locales";
 export default {
   data() {
     return {
-      locales: languages || []
+      locales: languages || [],
+      cameras: []
     };
   },
   computed: {
@@ -58,9 +76,16 @@ export default {
       } else {
         i18n.locale = navigator.language.split("-")[0];
       }
-      await api.put("/api/user", {
-        body: JSON.stringify({ locale })
-      });
+      await api.put("/api/user", { body: JSON.stringify({ locale }) });
+    },
+    async setCamera(event) {
+      const cameraId = event.target.value;
+      await api.put("/api/user", { body: JSON.stringify({ cameraId }) });
+    },
+    async getCameras() {
+      await navigator.mediaDevices.getUserMedia({ audio: false, video: true });
+      const devices = await navigator.mediaDevices.enumerateDevices();
+      this.cameras = devices.filter(device => device.kind === "videoinput");
     },
     async deleteMe() {
       this.$store.commit("popup/setPopup", {
@@ -115,6 +140,7 @@ select {
 }
 
 .select-language,
+.select-camera,
 .user-remove,
 .help-me,
 .log-out {
@@ -129,6 +155,7 @@ select {
 }
 
 .select-language,
+.select-camera,
 .help-me,
 .log-out {
   background: $grey-800;
diff --git a/client/src/locales/en.json b/client/src/locales/en.json
index cb3378b8..b8bc8920 100644
--- a/client/src/locales/en.json
+++ b/client/src/locales/en.json
@@ -63,6 +63,7 @@
     "help-option": "Help",
     "browser-language": "Browser language",
     "language-option": "Language",
+    "camera-option": "Camera",
     "logout-option": "Log out",
     "title": "Settings"
   },
diff --git a/client/src/locales/sv.json b/client/src/locales/sv.json
index d37ca988..ad80fead 100644
--- a/client/src/locales/sv.json
+++ b/client/src/locales/sv.json
@@ -63,6 +63,7 @@
     "help-option": "Hjälp",
     "browser-language": "Webbläsarens språk",
     "language-option": "Språk",
+    "camera-option": "Kamera",
     "logout-option": "Logga  ut",
     "title": "Inställningar"
   },
diff --git a/server/migrations/20240819-user-camera.sql b/server/migrations/20240819-user-camera.sql
new file mode 100644
index 00000000..82eb43bd
--- /dev/null
+++ b/server/migrations/20240819-user-camera.sql
@@ -0,0 +1,2 @@
+ALTER TABLE users
+ADD COLUMN camera_id INTEGER NOT NULL DEFAULT 1;
diff --git a/server/schema.sql b/server/schema.sql
index 01f94a53..a336ad5f 100644
--- a/server/schema.sql
+++ b/server/schema.sql
@@ -7,6 +7,7 @@ CREATE TABLE users (
   email      VARCHAR(255)  NOT NULL UNIQUE,
   photo      VARCHAR(255),
   locale     VARCHAR(2),
+  camera_id  INTEGER       NOT NULL DEFAULT 1,
   max_streak INTEGER       NOT NULL DEFAULT 0,
   is_admin   BOOLEAN       NOT NULL DEFAULT FALSE,
 
diff --git a/server/src/user/user-model.js b/server/src/user/user-model.js
index 53e16474..6e15547b 100644
--- a/server/src/user/user-model.js
+++ b/server/src/user/user-model.js
@@ -59,7 +59,7 @@ const SELECT_STREAK_SQL = () => `
 `;
 
 const SELECT_USERS_SQL = args => `
-  SELECT id, username, name, email, photo, locale, is_admin, created_at ${args}
+  SELECT id, username, name, email, photo, locale, camera_id, is_admin, created_at ${args}
   FROM users
 `;
 
@@ -113,7 +113,7 @@ module.exports = db => ({
   },
 
   update: async (id, user) => {
-    const valid = ["name", "photo", "locale", "max_streak"];
+    const valid = ["name", "photo", "locale", "camera_id", "max_streak"];
     const { keyIndices, values } = keyValuePairs(valid, user);
     const sql = `
         UPDATE users SET ${keyIndices}