Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fullnameOverride is not used #1653

Open
grdq opened this issue Oct 29, 2024 · 0 comments
Open

bug: fullnameOverride is not used #1653

grdq opened this issue Oct 29, 2024 · 0 comments

Comments

@grdq
Copy link

grdq commented Oct 29, 2024

Chart name and version
chart: victoria-metrics-cluster
version: v0.14.6

Describe the bug

I am upgrading from v0.11.18. One difference I have noticed is for my vmselect, vminsert, and vmstorage pods where in my values I have previously set a fullnameOverride for each one of this:

vmselect:
fullnameOverride: vmselect

vminsert:
fullnameOverride: vminsert

vmstorage:
fullnameOverride: vmstorage

This seems to no longer be respected, and the svc, deployment, sts name seems to follow this format:

{argocd.argoproj.io/instance}-{chart_name}-{vmselect/vminsert/vmstorage}

So if I am deploying this chart via an ArgoCD app called victoria-metrics-prod-eu then the sts, svc, and deployment, and therefore pod has an example name of:

victoria-metrics-prod-eu-victoria-metrics-cluster-vmstorage

instead of using the fullnameOverride like it did on the previous chart version I was using.

Has logic change in when it uses fullnameOverride in this time? Or is this not an issue you are seeing your end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant