Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow User to Set File Encoding #42

Open
tsmanner opened this issue Apr 11, 2018 · 1 comment
Open

Allow User to Set File Encoding #42

tsmanner opened this issue Apr 11, 2018 · 1 comment
Labels
enhancement New feature or request Epic

Comments

@tsmanner
Copy link
Collaborator

All encryption/decryption and file read/write is assuming a file encoding of UTF-8. We should add a setting and update the encryption api to consume it.
@tsmanner tsmanner added enhancement New feature or request Epic labels Apr 11, 2018
@tsmanner
Copy link
Collaborator Author

@manistal Does this actually matter? I'm playing with the file writing and Base64 stuff, it requires bytes objects not str objects. bytes have to be encoded, but I guess the Base64Engine can just decide it encodes as utf-8, and any other thing will be operating on the raw bytes and yielding a string anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Epic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tsmanner