Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README link broken in Members issue #38

Closed
torianne02 opened this issue Oct 1, 2020 · 3 comments
Closed

README link broken in Members issue #38

torianne02 opened this issue Oct 1, 2020 · 3 comments
Labels
Reserved for Learners These issues are reserved for people new to coding and/or Open Source contributions. Status: Available This issue is free to be worked on (pick me!) Type: documentation Improvements or additions to documentation

Comments

@torianne02
Copy link
Contributor

Describe the bug

On issue #13 there is a link to the README with instructions to get the site running locally. This link is broken.

To Reproduce

Steps to reproduce the behavior:

  1. Go to issue Add your profile to our Members Page! #13
  2. Scroll down to How to add yourself section
  3. Click on Local Development steps listed in our README link
  4. See error

Expected behavior

This link should direct the user to README#local-development

Screenshots

(If applicable, add screenshots to help explain your problem.)

Desktop (please complete the following information):

  • OS: macOS 10.15.6
  • Browser: chrome
  • Version: 85.0.4183.121

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

  • I did not include the proper URL for the purpose of allowing someone to explore and find it themselves.

Happy Coding 🎃

@BekahHW BekahHW added Type: documentation Improvements or additions to documentation Reserved for Learners These issues are reserved for people new to coding and/or Open Source contributions. Status: Available This issue is free to be worked on (pick me!) labels Oct 1, 2020
@danieltott
Copy link
Member

Really thought you could do relative links in GitHub markdown 😡

@MikeRogers0
Copy link
Contributor

MikeRogers0 commented Oct 6, 2020

@danieltott I think you can, it just needs to use the full url:

Local Development steps listed in our README

[Local Development steps listed in our README](https://github.com/Virtual-Coffee/virtualcoffee.io/#local-development)

@danieltott
Copy link
Member

@MikeRogers0 That definitely works, but only for the README - the thing I was trying to pull off was a link that would link to a markdown file in the repo, and like automatically point to the file in the default branch. We have the same problem with the link to CONTRIBUTING. I think this works in markdown files in the repo, but not in issues.

Thanks for the help @MikeRogers0 and @torianne02 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reserved for Learners These issues are reserved for people new to coding and/or Open Source contributions. Status: Available This issue is free to be worked on (pick me!) Type: documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants