Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After a test is complete, current working directory still points to a sandbox git repo from the previous test #1400

Open
PawelLipski opened this issue Feb 17, 2025 · 1 comment
Labels
code quality Quality of the code nees improving testing Relates to testing and testability

Comments

@PawelLipski
Copy link
Collaborator

This might lead to non-determinism in tests, as a test lacking create_repo() will then use underlying repo from the previous run.

@PawelLipski PawelLipski added code quality Quality of the code nees improving testing Relates to testing and testability labels Feb 17, 2025
@PawelLipski
Copy link
Collaborator Author

Maybe in teardown method just remove all repos created by the current test? This would require create_repo_with_remote() calls to be instance methods of BaseTest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Quality of the code nees improving testing Relates to testing and testability
Projects
None yet
Development

No branches or pull requests

1 participant