Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controlling a horse via the reins lack visual feedback. #260

Open
kevina opened this issue Mar 1, 2024 · 20 comments
Open

Controlling a horse via the reins lack visual feedback. #260

kevina opened this issue Mar 1, 2024 · 20 comments
Labels

Comments

@kevina
Copy link

kevina commented Mar 1, 2024

In 1.12 it is obvious how your hands control the reins after you mount a house thanks to the "much better cosmetic display" introduced in 1.1.12 v5. Basically the rein where attached to your hands and not just the horse. Newer versions lack this visual feedback making controlling a horse confusing.

Originally reported against 1.16 and still and issue with 1.20: jrbudda/Vivecraft_116#13

@fayer3
Copy link
Member

fayer3 commented Mar 1, 2024

what is a rein?

@fayer3
Copy link
Member

fayer3 commented Mar 1, 2024

do you have a screenshot of what you mean?

@kevina kevina changed the title Controlling a horse via the rein lack visual feedback. Controlling a horse via the reins lack visual feedback. Mar 1, 2024
@kevina
Copy link
Author

kevina commented Mar 1, 2024

what is a rein?

what is used to control the horse in real life, see https://www.merriam-webster.com/dictionary/rein for an illustration

do you have a screenshot of what you mean?

not at the moment, but if you try and ride a horse in 1.12 it will become obvious what I mean

@fayer3
Copy link
Member

fayer3 commented Mar 1, 2024

screenshot for reference
grafik
and code links
https://github.com/jrbudda/Vivecraft_112/blob/master/patches/net/minecraft/client/model/ModelHorse.java.patch

you only want the visual rein, or also the control stuff it comes with?

@fayer3 fayer3 added enhancement New feature or request missing old feature labels Mar 1, 2024
@fayer3
Copy link
Member

fayer3 commented Mar 1, 2024

was removed in 1.15 btw, probably because of the rendering changes, and then forgotten

@kevina
Copy link
Author

kevina commented Mar 1, 2024

The controller stuff is still there, but it lacks the visual feedback. I could not figure out how to ride a horse until I played 1.12.

@fayer3
Copy link
Member

fayer3 commented Mar 1, 2024

no it's not. the horse tracker is non functional atm, it's just the same as regular movement, point an walk

public boolean isActive(LocalPlayer p) {
return false;
}

@kevina
Copy link
Author

kevina commented Mar 1, 2024

That was not my experience when ridding a horse with 1.20. I need to double check with the latest and compare to 1.12 and get back to you.

@fayer3
Copy link
Member

fayer3 commented Mar 1, 2024

horse rotations is same as your in room rotation iirc

@kevina
Copy link
Author

kevina commented Mar 1, 2024

I did some testing and can confirm that controlling the horse still rotates as if it had reins. At least with my setup with index controllers. The thumb stick is configured to control movement, and the movement direction being controlled by where the left controller is pointing. To verify there was nothing strange about my setup I did this using a clean install in a new folder.

To test this, mount a horse in 1.20, hold your left arm forward than move your right arm, the horse will rotate. Now press forward, the horse will move the direction it is pointing, not the direction the left controller is pointing.

I also tested in 1.12.2-jrbudda-11-r2 and interestingly (at least with the default settings) the horse will just move in the direction you are pointing in-spite of the fact the reins are controlling the direction the horse is pointing.

@fayer3
Copy link
Member

fayer3 commented Mar 1, 2024

trying it out, I think that is just the a side effect, of how the player model forward rotaion is done, and the fore points where the player model is pointing at

@kevina
Copy link
Author

kevina commented Mar 1, 2024

On closer inspection I think you are right as rotating my head without moving my hands changes the direction slightly.

I think the real bug is that the horse moves the direction it is pointing, not the direction your controller is pointing. I will open a new bug report for that.

@fayer3
Copy link
Member

fayer3 commented Mar 1, 2024

it moves the direction you point at though

@kevina
Copy link
Author

kevina commented Mar 1, 2024

Not for me. I just double checked, although it's not always in the direction the horse is pointing.

@fayer3
Copy link
Member

fayer3 commented Mar 1, 2024

are you playing with controller freemove mode, or hmd?

@kevina
Copy link
Author

kevina commented Mar 1, 2024

controller freemove

@fayer3
Copy link
Member

fayer3 commented Mar 1, 2024

hm, it's using the main hand for some reason

@kevina
Copy link
Author

kevina commented Mar 1, 2024

yeah your right

@fayer3
Copy link
Member

fayer3 commented Mar 1, 2024

no it's not. the horse tracker is non functional atm, it's just the same as regular movement, point an walk

public boolean isActive(LocalPlayer p) {
return false;
}

also I double checked that on 1.12, the rein horse interaction isn't active there either, when active, it would allow to pull and snap the reins to get hte horse into a auto walk mode

@kevina
Copy link
Author

kevina commented Mar 1, 2024

sorry for the noise then, assuming #261 gets fixed, I consider this issue a very low priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants