From bee5cec8177e4027f0a2c644c2e0179c65ddcd8d Mon Sep 17 00:00:00 2001 From: Griffin Bassman Date: Fri, 17 Nov 2023 12:07:20 -0500 Subject: [PATCH] fix: ParseInsitu is not compatable with rlclientlib C# bindings --- vowpalwabbit/json_parser/src/parse_example_slates_json.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/vowpalwabbit/json_parser/src/parse_example_slates_json.cc b/vowpalwabbit/json_parser/src/parse_example_slates_json.cc index f4d99f6c8f5..1ae7b3078dc 100644 --- a/vowpalwabbit/json_parser/src/parse_example_slates_json.cc +++ b/vowpalwabbit/json_parser/src/parse_example_slates_json.cc @@ -223,7 +223,7 @@ void VW::parsers::json::details::parse_slates_example_json(const VW::label_parse VW::example_factory_t example_factory, const std::unordered_map* dedup_examples) { Document document; - document.ParseInsitu(line); + document.Parse(line); // Build shared example const Value& context = document.GetObject(); @@ -248,7 +248,7 @@ void VW::parsers::json::details::parse_slates_example_dsjson(VW::workspace& all, const std::unordered_map* dedup_examples) { Document document; - document.ParseInsitu(line); + document.Parse(line); // Build shared example const Value& context = document["c"].GetObject(); VW::multi_ex slot_examples;