Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Charge Response of PMTs #7

Open
marc1uk opened this issue Aug 30, 2019 · 0 comments
Open

Clarify Charge Response of PMTs #7

marc1uk opened this issue Aug 30, 2019 · 0 comments

Comments

@marc1uk
Copy link

marc1uk commented Aug 30, 2019

This is something that could be better documented in the guide and code, but it's currently not very clear how PMT charge response is defined, or the units of output. The wiki has a guide on adding a new photosensor, but simply says the qpe0 array 'represents spe response' and copies another detector. The units and scaling, for input or output, are not at all clear, especially with the various magic numbers (https://github.com/WCSim/WCSim/blob/develop/src/WCSimWCPMT.cc#L75) involved in the process.

It would be good to be explicit about the entire calculation chain, the units involved at each step, any rounding, thresholds, and how the PMT specification should be determined from a given physical detector in order to be able to reproduce e.g. a test stand setup to ensure MC aligns with measurements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant