Skip to content
This repository has been archived by the owner on Aug 14, 2019. It is now read-only.

"Update Comment" and "Cancel" should be buttons #9

Closed
afercia opened this issue Jun 3, 2017 · 0 comments
Closed

"Update Comment" and "Cancel" should be buttons #9

afercia opened this issue Jun 3, 2017 · 0 comments

Comments

@afercia
Copy link

afercia commented Jun 3, 2017

Currently, "Update Comment" and "Cancel" are links without a href attribute, they're rendered, for example. as:

<a class="save button-primary alignright"><span id="savebtn">Update Comment</span></a>
<a class="cancel button-secondary alignleft">Cancel</a>

Since they don't point to any resource and they perform an action instead, they should be buttons. See also #5 for more details.

Worth noting at the moment these links are not operable when using a keyboard because <a> elements without a href attribute aren't focusable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant