Skip to content
This repository has been archived by the owner on Feb 4, 2021. It is now read-only.

AFC/R is broken #199

Open
theopolisme opened this issue Oct 11, 2013 · 8 comments
Open

AFC/R is broken #199

theopolisme opened this issue Oct 11, 2013 · 8 comments

Comments

@theopolisme
Copy link
Contributor

@wikipedia-mabdul, it's been two days since you committed non-functional AFC/R code...could you please fix it?

TypeError: 'undefined' is not an object (evaluating 'from.to')

Thanks. If you don't have time to work on it right now, please just revert back to a stable version.

@wikipedia-mabdul
Copy link
Member

in which line is that? (L131?) I cannot confirm that problem here. neither using opera 12 nor chrome.

@theopolisme
Copy link
Contributor Author

Did you try it on enwiki using the latest version of develop?

Hmm, maybe my browser was doing weird caching...? Will look into tonight.

@wikipedia-mabdul
Copy link
Member

{{confirmed}} at enwp. will check

@theopolisme
Copy link
Contributor Author

Voila. :)

@wikipedia-mabdul can you do some serious testing of this code at enwiki, though? I just want to make sure there's nothing like this left over in it.

Thanks!

@theopolisme
Copy link
Contributor Author

I'm surprised; some of your committed code is really messed up, I'm afraid. Just try AFC/R:

First, for no apparent reason, one of these is set to autodecline...what?? Doesn't make sense.
screen shot 2013-10-12 at 12 30 31 am

And yet, when I get to something that SHOULD be declined, it isn't...wasn't this the whole point of your changes? And yet it isn't autodeclined?
screen shot 2013-10-12 at 12 30 37 am

theopolisme added a commit that referenced this issue Oct 12, 2013
@theopolisme
Copy link
Contributor Author

Fixed the above issues, you were using the wrong id numbers...

More problems:

I don't want you to feel any less valuable, but can we please just revert your changes and start fresh? @Technical-13 weigh in, perhaps? :/

@wikipedia-mabdul
Copy link
Member

the radom array was/is indented - use since ages that way
second q is good...

@theopolisme
Copy link
Contributor Author

@wikipedia-mabdul your response is complete gibberish... did you read my question?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants