Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CluStream.WithKmeans: How about changing the macro and micro clusters ids when getClusteringResult() is called, to show the labeling? #195

Open
onofricamila opened this issue Dec 12, 2019 · 0 comments

Comments

@onofricamila
Copy link

Hey! I was diving into the source code of
moa/moa/src/main/java/moa/clusterers/clustream/WithKmeans.java, and found out that it would be really useful if right after the user calls getClusteringResult(), the macro clusters returned have a unique id (current id is -1 for all of them), and then when the user calls getMicroClusteringResult(), these ones have a coherent id too, representing the former labeling (current micro clusters id is -1 for all of them) ...

It seems that the moa/moa/src/main/java/moa/cluster/Cluster.java setId() method is not used and I do not know if that is on purpose (like for some reason).

Having the micro clusters labeled would be useful for calculating metrics to see how well the clustering resulted, for plotting different groups with different colors, and so on.

If you think what I remarked is correct, I will submit a PR.

Any feedback is welcomed. Thanks!!

@onofricamila onofricamila changed the title CluStream.WithKmeans: Why not changing the macro and micro clusters id when getClusteringResult called to show the labeling CluStream.WithKmeans: How about changing the macro and micro clusters ids when getClusteringResult() is called, to show the labeling Dec 12, 2019
@onofricamila onofricamila changed the title CluStream.WithKmeans: How about changing the macro and micro clusters ids when getClusteringResult() is called, to show the labeling CluStream.WithKmeans: How about changing the macro and micro clusters ids when getClusteringResult() is called, to show the labeling? Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant