Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI broken #111

Closed
rossberg opened this issue Jul 19, 2024 · 2 comments
Closed

CI broken #111

rossberg opened this issue Jul 19, 2024 · 2 comments
Assignees

Comments

@rossberg
Copy link
Collaborator

Hey folks,

CI has been broken since this commit. The prose renderer incorrectly generates math with a macro invocation for \zbytes after this change. I don’t know where that’s coming from, something somehow bypasses the show hints in the Latex renderer. Could someone please investigate?

Please make sure that CI is always green. Either run make ci locally before pushing, or let github do it by creating a PR. And in case it's broken accidentally (can happen, I certainly have been guilty of that, usually when forgetting to promote test expectations), please fix it right away, even if that might require reverting the change.

@jaehyun1ee jaehyun1ee self-assigned this Jul 19, 2024
@presenthee presenthee removed their assignment Jul 19, 2024
@jaehyun1ee
Copy link

CI was broken after this commit, where it introduces an AST node InvCallE for inverse function application. The prose renderer did not handle the case properly, which broke the spec CI.

#109 handles the problem with InvCallE rendering, will merge on @rossberg's approval :)

@rossberg
Copy link
Collaborator Author

Cool, thanks for the fast fix!

Ah, I was inferring from the CI actions log, where the other commit was the first that showed that specific failure. Perhaps something else masked it on your commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants